[cfe-commits] [PATCH] Implement AST dumper for Decls

[Alexander Kornienko]

  I have no concerns except for a couple minor things in inline comments.

  But this patch needs Doug's review as well.


================
Comment at: lib/AST/ASTDumper.cpp:73
@@ -68,2 +72,3 @@
     void dumpType(QualType T);
-    void dumpDeclRef(Decl *node);
+    void dumpBareDeclRef(Decl *node);
+    void dumpDeclRef(Decl *node, const char *Label = NULL);
----------------
node -> Node, please. And did you consider making it "const Decl *"? Of course this only makes sense if the code isn't going to be filled with const_casts.
The same question for other similar methods below.

================
Comment at: lib/AST/ASTDumper.cpp:390
@@ +389,3 @@
+    OS << " integral";
+    OS << ' ' << A.getAsIntegral();
+    break;
----------------
I'd prefer
  OS << " integral " << A.getAsIntegral();
or
  OS << " integral ";
  OS << A.getAsIntegral();



http://llvm-reviews.chandlerc.com/D52