[cfe-commits] [PATCH] Warn is -isysroot is given an invalid path

[Chad Rosier]

On Dec 13, 2012, at 10:30 PM, Eric Christopher <echristo at gmail.com> wrote:

> On Thu, Dec 13, 2012 at 4:54 PM, Chad Rosier <mcrosier at apple.com> wrote:
> All,
> The attached patch emits a warning in the frontend if the -isysroot flag is given an invalid directory.  I've implemented this using llvm::sys:fs::exists(), but please let me know if FileManager::getStatValue() (or another option) is preferred; I'll modify the patch accordingly.  I'll also add a test case before pushing the final commit.
> 
> Curious: What's the motivation here? I can see it as being potentially more serious than -I /some/invalid/path but we don't warn on that one (at least as far as I know).

No, we don't.

> 
> Not against it, just curious. :)

It was requested by an internal developer to ease the burden of debugging build failures. :)

 Chad

> 
> -eric 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121214/d0cc39ef/attachment.html>