[cfe-commits] Fix search path for clang on latest DragonFly releases [revised patches]
draco at marino.st
Thu Dec 13 12:58:12 PST 2012
On 12/13/2012 21:02, Rafael Espíndola wrote:
>> Per request from Rafael, I have applied these release 3.1 patches to trunk.
>> They applied cleanly. The resulting diff is attached.
>> Please review to significantly improve clang's support on DragonFly!
> + bool UseGCC47;
> + llvm::sys::fs::exists("/usr/lib/gcc47", UseGCC47);
> UseGCC47 can be used uninitialized. From the code I guess you can use
> the simpler ]
> UseGCC47 = llvm::sys::fs::exists("/usr/lib/gcc47");
> The patch has grown quite a bit no? Can you split it? For example,
> just gcc47 bits, the hash-style bits, etc.
It grew because I did a full audit of what was getting set and found
several obsolete items. They all needed to be fixed so I submitted them
all at the same time.
I still consider this a *very simple* patch that only touches
DragonFly-specific functions. Is it really too hard to evaluate these
And yes, it has grown -- I listed all the changes on both a previous
post and the bug report I opened.
More information about the cfe-commits