[cfe-commits] r170089 - in /cfe/trunk: lib/StaticAnalyzer/Checkers/ObjCMissingSuperCallChecker.cpp test/Analysis/superclass.m test/Analysis/viewcontroller.m

[Jordan Rose]

Fixed in r170139.


On Dec 13, 2012, at 9:10 , Jordan Rose <jordan_rose at apple.com> wrote:

> Ha, oops! Thanks, Dmitri. Indeed, -Wdocumentation got the correct fix there; either Julian or I should have caught that! (And I should reset my build to add -Wdocumentation to my warnings...)
> 
> I don't have a clean tree right now but I'll check in the fix soon.
> 
> Jordan
> 
> 
> On Dec 13, 2012, at 5:19 , Dmitri Gribenko <gribozavr at gmail.com> wrote:
> 
>> On Thu, Dec 13, 2012 at 5:06 AM, Jordan Rose <jordan_rose at apple.com> wrote:
>>> +/// \brief Determine whether the given class has a superclass that we want
>>> +/// to check. The name of the found superclass is stored in SuperclassName.
>>> +///
>>> +/// \param ObjCImplementationDecl The declaration to check for superclasses.
>>> +/// \param[out] SuperclassName On return, the found superclass name.
>>> +bool ObjCSuperCallChecker::isCheckableClass(const ObjCImplementationDecl *D,
>>> +                                            StringRef &SuperclassName) const {
>> 
>> Hello Jordan,
>> 
>> clang -Wdocumentation complains:
>> 
>> /home/grib/clang-scp/llvm/tools/clang/lib/StaticAnalyzer/Checkers/ObjCMissingSuperCallChecker.cpp:89:12:
>> warning: parameter
>>    'ObjCImplementationDecl' not found in the function declaration
>> [-Wdocumentation]
>> /// \param ObjCImplementationDecl The declaration to check for superclasses.
>>         ^~~~~~~~~~~~~~~~~~~~~~
>> /home/grib/clang-scp/llvm/tools/clang/lib/StaticAnalyzer/Checkers/ObjCMissingSuperCallChecker.cpp:89:12:
>> note: did you mean 'D'?
>> /// \param ObjCImplementationDecl The declaration to check for superclasses.
>>         ^~~~~~~~~~~~~~~~~~~~~~
>>         D
>> 
>> Dmitri
>> 
>> -- 
>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
>