[cfe-commits] [Patch] Initial FreeBSD ARM support

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Dec 12 20:19:07 PST 2012


r170096.

On 12 December 2012 16:39, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Wed, Dec 12, 2012 at 2:21 AM, Andrew Turner <andrew at fubar.geek.nz> wrote:
>> On Sun, 9 Dec 2012 15:06:54 +1300
>> Andrew Turner <andrew at fubar.geek.nz> wrote:
>>
>>> I have attached a new patch that updates the tests.
>>
>> Were there any issues with this patch or can it be committed?
>
> +      if (getTriple().getOS() != llvm::Triple::FreeBSD) {
> +        SizeType = UnsignedLong;
> +      }
>
> No braces for simple if statements.
>
> Otherwise, LGTM.
>
> -Eli
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list