[cfe-commits] [PATCH] [msan] Add simplifycfg before msan at O0

Chandler Carruth chandlerc at google.com
Tue Dec 11 23:39:02 PST 2012


Why not just remove unreachable blocks in mean directly? It's pretty simple
and certainly cheaper than a full simplifycfg pass...
On Dec 11, 2012 11:35 PM, "Evgeniy Stepanov" <eugenis at google.com> wrote:

> Hi kcc,
>
> MemorySanitizer can't handle unreachable BB's
>
> http://llvm-reviews.chandlerc.com/D207
>
> Files:
>   lib/CodeGen/BackendUtil.cpp
>
> Index: lib/CodeGen/BackendUtil.cpp
> ===================================================================
> --- lib/CodeGen/BackendUtil.cpp
> +++ lib/CodeGen/BackendUtil.cpp
> @@ -188,6 +188,9 @@
>
>  static void addMemorySanitizerPass(const PassManagerBuilder &Builder,
>                                     PassManagerBase &PM) {
> +  // MSan does not like unreachable BB's.
> +  if (Builder.OptLevel == 0)
> +    PM.add(createCFGSimplificationPass());
>    PM.add(createMemorySanitizerPass());
>  }
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121211/a6e5013b/attachment.html>


More information about the cfe-commits mailing list