[cfe-commits] r169865 - /cfe/trunk/lib/AST/StmtDumper.cpp

Sean Silva silvas at purdue.edu
Tue Dec 11 22:05:45 PST 2012

On Tue, Dec 11, 2012 at 9:49 PM, Alexander Kornienko <alexfh at google.com> wrote:
> I didn't resist the temptation to use Phabricator's command-line tool
> (arcanist) to commit the patch.

That's what I suspected. It's not that big of a deal since as you
mentioned the link takes you to full information.

Manuel, since you seem to be our ambassador with the Phab folks, is
there some way you could file this use case upstream and see what they
come up with? (if you haven't been following along, basically when
committing through arc, Phab doesn't include an attribution message
like "Patch by J. Random Hacker!" to the commit message as is
prescribed in <http://llvm.org/docs/DeveloperPolicy.html#attribution-of-changes>).
I believe Phab has all the info it needs to determine this based on
the code review, so hopefully it is straightforward to have it tack on
an extra line at the end of the commit message.

-- Sean Silva

More information about the cfe-commits mailing list