[cfe-commits] [PATCH] Simplify isPowerOfTwo signature

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Dec 11 17:05:30 PST 2012

> I think that's Chandler's point—the interface shouldn't imply that it's a
> target-independent predicate, even though the current implementation is.
> What about renaming to isKnownPowerOfTwo, to make it clear that the target
> could affect the answer?

Those are independent, no? I do like isKnownPowerOfTwo better, since
sometimes, with or without the target, we just don't know.

But if we are not using the target, passing TargetData gives the
impression that it is used, when in fact it is not.


More information about the cfe-commits mailing list