[cfe-commits] [Patch] SPIR32/SPIR64 targets in Clang

Eli Friedman eli.friedman at gmail.com
Tue Dec 11 13:28:24 PST 2012

On Tue, Dec 11, 2012 at 6:49 AM, Benyei, Guy <guy.benyei at intel.com> wrote:
> Hi Eli,
> Thanks for the review.
> Attached a fixed patch, please review.
>> +    virtual bool hasFeature(StringRef Feature) const {
>> +      return Feature == "spir";
>> +    }
>> What's the point of this?
> This one is quite the same as in every virtual architecture, including PNaCl/le32. I guess it is a convinient way to find out if the current target implements this kind of abstraction.

Looks fine.

(I was confused by your testcase for a little while, but then I
figured out that the default optimization level is different for
OpenCL compared to C.)


More information about the cfe-commits mailing list