[cfe-commits] [PATCH] Speed up parsing of global declarations.

Manuel Klimek klimek at google.com
Tue Dec 11 12:15:40 PST 2012

Comment at: lib/Basic/DiagnosticIDs.cpp:226
@@ +225,3 @@
+/// \brief Cache lookup of the DiagID -> ClassInfo ID mapping.
+static std::pair<unsigned, bool> DiagnosticClassCache[diag::DIAG_UPPER_LIMIT];
Nope, Benjamin brought that up on IRC already (which led to him checking in a first patch to speed up GetDiagInfo).

I'm now doing more benchmarks, and if this turns out to be still needed, Benjamin said that putting it into DiagnosticIDs is probably fine.


More information about the cfe-commits mailing list