[cfe-commits] [PATCH] Simplify isPowerOfTwo signature

Sebastian Redl sebastian.redl at getdesigned.at
Tue Dec 11 01:01:59 PST 2012


On 11.12.2012 08:06, Duncan Sands wrote:
> Hi Saleem, why do you want this?  While isPowerOfTwo doesn't use data 
> layout
> today, it's not unreasonable to imagine that it may use it one day.  
> As such,
> requiring target data can be considered part of the isPowerOfTwo API.
Without knowing anything about the specific use case of this function, 
my intuition is that "is power of two" is a purely mathematical 
property, and if it's influenced by TargetData, something is wrong.

Sebastian



More information about the cfe-commits mailing list