[cfe-commits] [PATCH] Add i686-linux-android for gcc toolchain detection

Logan Chien tzuhsiang.chien at gmail.com
Thu Dec 6 15:02:19 PST 2012


Committed as r169557.  Thanks.

Logan


On Fri, Dec 7, 2012 at 6:16 AM, Logan Chien <tzuhsiang.chien at gmail.com>wrote:

> Yes.  The integrated assembler is enabled by default in i686/linux,
> so I didn't add the test case for i686 assembler.  Thanks for your
> review.
>
> Logan
>
>
>
> On Thu, Dec 6, 2012 at 9:02 PM, Evgeniy Stepanov <
> eugeni.stepanov at gmail.com> wrote:
>
>> Looks good.
>> Do we use intergrated assembler on i686/linux? There is no -as line
>> for that case in the newly added test.
>>
>> On Thu, Dec 6, 2012 at 5:58 AM, Logan Chien <tzuhsiang.chien at gmail.com>
>> wrote:
>> > Ping.  The rebased patch is attached.
>> >
>> >
>> >
>> > On Thu, Nov 15, 2012 at 11:36 AM, Logan Chien <
>> tzuhsiang.chien at gmail.com>
>> > wrote:
>> >>
>> >> Dear all,
>> >>
>> >>   The GCCInstallationDetector can't detect the GCC for X86 in NDK
>> >> (i686-linux-android.)  The attached patch should fix the problem, and
>> >> slightly enhance the test cases.  Please have a look.  Thanks.
>> >>
>> >> Logan
>> >
>> >
>> >
>> > _______________________________________________
>> > cfe-commits mailing list
>> > cfe-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>> >
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121207/ff51ea5b/attachment.html>


More information about the cfe-commits mailing list