[cfe-commits] web code review not integrating emails

Manuel Klimek klimek at google.com
Thu Dec 6 01:50:35 PST 2012


On Wed, Dec 5, 2012 at 11:50 PM, Tobias Grosser <tobias at grosser.es> wrote:

> On 12/05/2012 11:45 PM, Hal Finkel wrote:
>
>> ----- Original Message -----
>>
>>> From: "Tobias Grosser"<tobias at grosser.es>
>>> To: "Hal Finkel"<hfinkel at anl.gov>
>>> Cc: cfe-commits at cs.uiuc.edu, reviews+D149+public+**
>>> 707ba5224a940551 at llvm-reviews.**chandlerc.com<reviews%2BD149%2Bpublic%2B707ba5224a940551 at llvm-reviews.chandlerc.com>
>>> Sent: Wednesday, December 5, 2012 4:37:01 PM
>>> Subject: Re: [cfe-commits] [PATCH] Invariants (and Assume Aligned) -
>>> Clang
>>>
>>
> [...]
>
>  [For some reason, I can't see this comment in the web interface].
>>>>
>>>
>>> I have no account for the web interface, but hoped the emails would
>>> show
>>> up there anyway. Is this not the case?
>>>
>>
>> It seems not.
>>
>
> Chandler, any idea why your new web interface does not show review mails
> from the mailing list?
>

Yes, it's not implemented :)

Parsing emails that come from a myriad of different mail programs is hard -
we can come up with heuristics, but it's not trivial to add, and thus
requires some work. I want to spend some "fun coding" time on that task at
some point (especially as more people start using phab), but it's so far
not top priority.

Cheers,
/Manuel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121206/b3236a72/attachment.html>


More information about the cfe-commits mailing list