[cfe-commits] [PATCH] Error recovery part 2

Manuel Klimek klimek at google.com
Tue Dec 4 11:54:05 PST 2012


  lg


================
Comment at: lib/Format/UnwrappedLineParser.cpp:55
@@ -53,3 +54,3 @@
     case tok::r_brace:
-      return;
+      return false;
     default:
----------------
Can we please add a fixme so this doesn't get lost later...

================
Comment at: lib/Format/Format.cpp:700
@@ -690,2 +699,3 @@
 private:
   virtual void formatUnwrappedLine(const UnwrappedLine &TheLine) {
+    UnwrappedLines.push_back(TheLine);
----------------
In one of the next CLs I'm for renaming this method (and the method in the interface) to onUnwrappedLine or something similar, so that it doesn't look like we're actually formatting anything here.

================
Comment at: lib/Format/Format.cpp:318
@@ -316,2 +317,3 @@
   /// \brief Add a new line and the required indent before the first Token
   /// of the \c UnwrappedLine.
+  unsigned formatFirstToken() {
----------------
/// of the \c UnwrappedLine if there was no structural parsing error.
/// Returns the indent level of the \c UnwrappedLine.


http://llvm-reviews.chandlerc.com/D164

COMMIT
  http://llvm-reviews.chandlerc.com/rL169286



More information about the cfe-commits mailing list