[cfe-commits] Fix libstdc++ header search paths on Gentoo

[Timothy B. Terriberry]

Chandler Carruth wrote:
> Several folks have wanted to remove the break after the first one is
> found -- however, that is not a correct change. We cannot add multiple
> libstdc++ versions' include trees to compiles, and removing the break
> runs the risk of that.

If that's the only concern, I'd be happy to modify the patch to stop 
once it finds a combination of directories that provides both of the 
candidate headers I'm looking for in this patch.

> IMO, Gentoo's layout is broken. You should file a bug with them asking
> them to install libstdc++ headers in a way compatible (or ideally
> *exactly the same*) as what the upstream GCC project will do if you run
> 'make install'. If that doesn't work for Gentoo for some reason, they
> should talk to the GCC and libstdc++ developers to resolve that issue
> rather than making everyone customize their tools on the Gentoo platform.

Well, from my perspective, I _need_ GCC to work on Gentoo, while clang 
currently doesn't work at all, so given the many existing Gentoo 
installs configured like this and the relatively low penetration of 
clang, the safer and easier course is to fix clang... The fact that this 
code exists at all (which I think is frankly insane) suggests the 
"expect everybody to do things the same" ship has sailed.

But honestly, I just wasted several hours of my time fixing several 
clang issues, all of which had been known and reported fully one or more 
years ago. I thought I'd help the next guy out and forward my patches 
along, but if you're not interested in taking them, I've got a lot 
better things to do with my time than argue.