[cfe-commits] [PATCH] [libcxx][CMake] Add initial support for selecting a specific c++ abi to use.

Chandler Carruth chandlerc at gmail.com
Thu Nov 29 16:10:05 PST 2012


  Looks good!


================
Comment at: lib/CMakeLists.txt:35
@@ -34,2 +34,3 @@
 # Generate library list.
+set(libraries ${LIBCXX_CXX_ABI_LIBRARIES})
 append_if(libraries LIBCXX_HAS_PTHREAD_LIB pthread)
----------------
Michael Spencer wrote:
> Chandler Carruth wrote:
> > Why not use append_if for each line? Was the old code just broken?
> I'm not using append_if here because there's no conditional to test.
Doh, of course...


http://llvm-reviews.chandlerc.com/D82



More information about the cfe-commits mailing list