[cfe-commits] Fix search path for clang on latest DragonFly releases

John Marino draco at marino.st
Mon Nov 26 00:54:44 PST 2012


On 11/23/2012 20:02, Joerg Sonnenberger wrote:
> On Fri, Nov 23, 2012 at 07:41:26PM +0100, John Marino wrote:
>>   Tool&DragonFly::SelectTool(const Compilation&C, const JobAction&JA,
>> --- tools/clang/lib/Driver/Tools.cpp.orig	2012-04-18 21:32:25.000000000 +0000
>> +++ tools/clang/lib/Driver/Tools.cpp
>> @@ -5499,14 +5499,21 @@ void dragonfly::Link::ConstructJob(Compi
>>         !Args.hasArg(options::OPT_nodefaultlibs)) {
>>       // FIXME: GCC passes on -lgcc, -lgcc_pic and a whole lot of
>>       //         rpaths
>> -    CmdArgs.push_back("-L/usr/lib/gcc41");
>> +    CmdArgs.push_back("-L/usr/lib/gcc47");
>> +    CmdArgs.push_back("-L/usr/lib/gcc44");
>>
>>       if (!Args.hasArg(options::OPT_static)) {
>>         CmdArgs.push_back("-rpath");
>> -      CmdArgs.push_back("/usr/lib/gcc41");
>> +      CmdArgs.push_back("/usr/lib/gcc47");
>>
>>         CmdArgs.push_back("-rpath-link");
>> -      CmdArgs.push_back("/usr/lib/gcc41");
>> +      CmdArgs.push_back("/usr/lib/gcc47");
>> +
>> +      CmdArgs.push_back("-rpath");
>> +      CmdArgs.push_back("/usr/lib/gcc44");
>> +
>> +      CmdArgs.push_back("-rpath-link");
>> +      CmdArgs.push_back("/usr/lib/gcc44");
>>
>>         CmdArgs.push_back("-rpath");
>>         CmdArgs.push_back("/usr/lib");
>
> This part doesn't make sense. -rpath includes -rpath-link...

I was just extending what was already there.
If it's felt that -rpath-link is redundant then I don't have issue with 
removing it completely.

However, what is the process to see this bug report 14417 accomplished? 
I don't really want to stay subscribed to this mailing list for a single 
patch.  I would have thought opening a bug report alone would have been 
sufficient.

John



More information about the cfe-commits mailing list