[cfe-commits] [PATCH] Add -ldl for libgcc in Android environment

Chandler Carruth chandlerc at google.com
Mon Nov 19 03:02:45 PST 2012


LGTM with the following tweak:

+  if (!StaticLibgcc && isAndroid)
+    CmdArgs.push_back("-ldl");

I would start with the 'isAndroid' condition just to make it more
clear that this is an android-specific hack. I would also add a
comment similar to your original email. It is really important to
document this type of surprising constraint in the source, not just in
the email. ;]



More information about the cfe-commits mailing list