[cfe-commits] [PATCH] Initial version of formatting library

Daniel Jasper djasper at google.com
Sat Nov 17 00:41:00 PST 2012


  I will fix up the other nit picks before submitting ..


================
Comment at: lib/Format/Format.cpp:49
@@ +48,3 @@
+    // Start iterating at 1 as we have correctly formatted of Token #0 above.
+    for (unsigned i = 1, n = Line.Tokens.size(); i != n; ++i) {
+      bool InsertNewLine = Line.Tokens[i].NewlinesBefore > 0;
----------------
Sean Silva wrote:
> These variables should be capitalized.
You mean as opposed to pretty much every example on http://llvm.org/docs/CodingStandards.html?

Also, they use e, not n, so I am going to change that back.


http://llvm-reviews.chandlerc.com/D80



More information about the cfe-commits mailing list