[cfe-commits] r165591 - in /cfe/trunk: include/clang/Basic/Module.h lib/Frontend/FrontendActions.cpp lib/Serialization/ASTReader.cpp

[Argyrios Kyrtzidis]

On Nov 15, 2012, at 8:55 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> On Wed, Oct 10, 2012 at 5:12 AM, Argyrios Kyrtzidis <akyrtzi at gmail.com> wrote:
>> Author: akirtzidis
>> Date: Tue Oct  9 21:12:39 2012
>> New Revision: 165591
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=165591&view=rev
>> Log:
>> [modules] Consistently construct a buffer as input to build the module.
>> This means the main file for modules will always be a virtual one.
> 
> Hi Argyrios,
> 
> This made err_missing_umbrella_header unused.  OK to remove it?

Yes, thanks for catching it.

> 
> Dmitri
> 
> Index: include/clang/Basic/DiagnosticFrontendKinds.td
> ===================================================================
> --- include/clang/Basic/DiagnosticFrontendKinds.td	(revision 168040)
> +++ include/clang/Basic/DiagnosticFrontendKinds.td	(working copy)
> @@ -129,8 +129,6 @@
>   DefaultFatal;
> def err_missing_module : Error<
>   "no module named '%0' declared in module map file '%1'">, DefaultFatal;
> -def err_missing_umbrella_header : Error<
> -  "cannot open umbrella header '%0': %1">, DefaultFatal;
> def err_no_submodule : Error<"no submodule named %0 in module '%1'">;
> def err_no_submodule_suggest : Error<
>   "no submodule named %0 in module '%1'; did you mean '%2'?">;
> 
> -- 
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/