[cfe-commits] [PATCH] Add -ast-dump-depth option

Dmitri Gribenko gribozavr at gmail.com
Tue Nov 13 01:46:04 PST 2012


  LGTM.


================
Comment at: lib/AST/StmtDumper.cpp:52
@@ -56,3 +51,3 @@
   public:
-    StmtDumper(SourceManager *sm, raw_ostream &os, unsigned maxDepth)
-      : SM(sm), OS(os), IndentLevel(0), IsFirstLine(true), MaxDepth(maxDepth) {
+    StmtDumper(SourceManager *sm, raw_ostream &os)
+      : SM(sm), OS(os), IndentLevel(0), IsFirstLine(true) {
----------------
Since you are already changing this constructor, could you please adjust sm to SM, os to OS to match coding guidelines, and use member initialization list for the initialization done in the body?


http://llvm-reviews.chandlerc.com/D98



More information about the cfe-commits mailing list