[cfe-commits] [patch] Change return type of CommentHandler::HandleComment() from bool to void

[Abramo Bagnara]

Il 12/11/2012 04:02, Nico Weber ha scritto:
> Hi,
> 
> CommentHandler::HandleComment() returns bool, but all implementers
> return false. The attached patch changes the return type to void,
> which makes it possible to delete minor amounts of code.

Please don't change that: to return a boolean is fundamental to permit
to replace comments with other tokens during parsing.

We do use that and it is *very* useful to handle comment shaped annotations.

-- 
Abramo Bagnara

BUGSENG srl - http://bugseng.com
mailto:abramo.bagnara at bugseng.com