[cfe-commits] r167651 - in /cfe/trunk: include/clang/AST/DeclCXX.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/CXXInheritance.cpp lib/Sema/SemaDeclCXX.cpp test/SemaTemplate/dependent-names.cpp

Jordan Rose jordan_rose at apple.com
Fri Nov 9 19:24:02 PST 2012


On Nov 9, 2012, at 19:23 , Douglas Gregor <dgregor at apple.com> wrote:

> 
> On Nov 9, 2012, at 6:53 PM, Jordan Rose <jordan_rose at apple.com> wrote:
> 
>> This isn't actually a circular dependence, either. IntervalMap<>::const_iterator is inheriting from std::iterator.
>> 
>> I don't see anything obviously wrong with your patch, though...
> 
> I see the problem in my patch. CXXRecordDecl::forallBases has a ridiculously non-intuitive API.

Also your predicate is named backwards from what it actually does. :-)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121109/b85859d5/attachment.html>


More information about the cfe-commits mailing list