[cfe-commits] [patch] Fixing warnings in libc++'s locale header

[Howard Hinnant]

On Oct 22, 2012, at 3:07 AM, Dimitry Andric <dimitry at andric.com> wrote:

> Hi,
> 
> This fixes a few warnings that occur in libc++'s headers, when building
> with -Wsystem-headers:
> 
> In file included from /usr/include/c++/v1/iostream:40:
> In file included from /usr/include/c++/v1/istream:156:
> In file included from /usr/include/c++/v1/ostream:132:
> /usr/include/c++/v1/locale:2878:25: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
>        {pattern __p = {symbol, sign, none, value}; return __p;}
>                        ^~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/include/c++/v1/locale:2880:25: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
>        {pattern __p = {symbol, sign, none, value}; return __p;}
>                        ^~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/include/c++/v1/locale:3194:35: error: unused variable '__et' [-Werror,-Wunused-variable]
>                ios_base::iostate __et = ios_base::goodbit;
>                                  ^
> 
> The first two warnings are because money_base::pattern is declared as a
> struct containing a char array, so the char array itself needs
> additional braces.
> 
> The third warning is because r152501 changed some code in __do_get()'s
> money_base::symbol case, which made the __et variable unnecessary.
> 
> -Dimitry
> <libcxx-fix-locale-warnings-1.diff>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Thanks, Committed revision 167492.

Howard