[cfe-commits] Looking for reviewers

David Blaikie dblaikie at gmail.com
Tue Nov 6 08:35:18 PST 2012


Looks like Chandler's signed off on this. I assume he meant to approve
it but didn't click the right button. You just need someone to commit
this - we often assume people have commit access, if you get a code
review sign off & the person doesn't commit it you can just reply with
"Thanks, could you commit this"

(+Chandler who might want to actually approve the review in Phab just
for fun/profit and may commit for you if someone else doesn't do it
first)

On Tue, Nov 6, 2012 at 8:16 AM, Vane, Edwin <edwin.vane at intel.com> wrote:
> Hi all,
>
> I have a revision on phabricator (http://llvm-reviews.chandlerc.com/D94) that needs extra reviewers to mark it as accepted and hopefully commit on my behalf since I don't currently have write privileges. Could somebody take a quick look at it?
>
> --
> Edwin Vane
>   Software Developer
>   SSG/DPD/ECDL/DMP
>   Phone: +1 519 772 2567
>   iNET: 87722567
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list