[cfe-commits] Micro-patch: Unify VoidModuleLoaders

Chandler Carruth chandlerc at google.com
Mon Nov 5 03:39:58 PST 2012


I like the direction of this, but I think it should go into a
unittest-specific library.

We don't currently have any such library infrastructure, but honestly,
I think we need it and we should get it in place sooner rather than
later.

Adding Manuel as he may have ideas here.

On Sun, Nov 4, 2012 at 11:27 AM, Kim Gräsman <kim.grasman at gmail.com> wrote:
> Hi committers,
>
> I contributed a small patch a few weeks ago, adding unittests for
> PPCallbacks::InclusionDirective.
>
> I was bugged by the proliferation of stub ModuleLoader implementations but
> didn't want to do anything about it in that context.
>
> Here's a patch to move VoidModulerLoader into ModuleLoader.h and remove all
> redundant implementations.
>
> Could someone review and commit if this is acceptable?
>
> Thanks,
> - Kim
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>




More information about the cfe-commits mailing list