[cfe-commits] [PATCH] Fix x86 android support in clang

[Rafael Espíndola]

On 1 November 2012 15:59, Edwin Vane <edwin.vane at intel.com> wrote:
>   Instead of using 'atom' as default cpu name, after some internal consultation, 'core2' is a better common denominator for x86 android. Added tests to test/Driver/clang-translation.c.

Why? Can you add a comment saying why core2 makes sense?

> +  const bool isAndroid = getToolChain().getTriple().getEnvironment() ==
> +                         llvm::Triple::Android;

I think it is more common to break after the =, not the ==, would that fit?

LGTM with those changes.

Cheers,
Rafael