[cfe-commits] [PATCH] crash on invalid namespace-alias-definition syntax

Nico Weber thakis at chromium.org
Fri Oct 26 22:16:06 PDT 2012

Thanks for the patch!

Instead of adding a bool, can you just check if Ident is not 0? Also,
can you please add a test case? You can add the whole test suite with
`make test` and an individual test e.g. like `../../utils/lit/lit.py
-v test/Parser/cxx-member-crash.cpp`. Maybe you can just create
test/Parser/cxx-crash.cpp which can become a collection of parser
crash tests.


On Fri, Oct 26, 2012 at 10:07 PM, Brian Brooks <brooks.brian at gmail.com> wrote:
> Attached is a patch for the following bug:
> http://llvm.org/bugs/show_bug.cgi?id=14085
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

More information about the cfe-commits mailing list