[cfe-commits] r166655 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/TargetInfo.h lib/Basic/Targets.cpp lib/Sema/SemaStmtAsm.cpp test/Misc/warning-flags.c

John McCall rjmccall at apple.com
Wed Oct 24 18:50:56 PDT 2012

On Oct 24, 2012, at 5:32 PM, Bill Wendling wrote:
> Author: void
> Date: Wed Oct 24 19:32:44 2012
> New Revision: 166655
> URL: http://llvm.org/viewvc/llvm-project?rev=166655&view=rev
> Log:
> Revert r166647 to rethink the patch...

FWIW, Eli's review just means that you shouldn't ever add a warning
without putting it in a warning group.  But in general, please don't
speculatively add warnings that you don't intend to support;  the
diagnostic text here is worryingly wishy-washy.


More information about the cfe-commits mailing list