[cfe-commits] [PATCH] Add unit tests for source locations of AST nodes

[Philip Craig]

================
Comment at: unittests/AST/SourceLocationTest.cpp:38
@@ +37,3 @@
+                                 const MatcherType &AMatcher, Language L);
+
+  virtual void run(const MatchFinder::MatchResult &Result);
----------------
Manuel Klimek wrote:
> Can all methods after here be protected?
Yes.

================
Comment at: unittests/AST/SourceLocationTest.cpp:99
@@ +98,3 @@
+/// By default, Node.getSourceLocation() is checked. This can be changed
+/// by overriding getLocation().
+template <typename NodeType>
----------------
Manuel Klimek wrote:
> Are you already seeing a use case for this (as in: one of the next patches you do will use this) or is this purely speculative?
It's needed to test any location that isn't an endpoint of the range of a node. A good example is BinaryOperator::getOperatorLoc().


http://llvm-reviews.chandlerc.com/D72