[cfe-commits] [PATCH] AST matcher tutorial (Part I)

Manuel Klimek klimek at google.com
Wed Oct 24 00:43:59 PDT 2012

  I'm generally for putting all the TBD parts into comments, and getting a first version out there once we verified all the code samples compile...

Comment at: docs/LibASTMatchersTutorial.html:131
@@ +130,3 @@
+<tt>tools/loop-convert/loop-convert.cpp</tt>. A detailed explanation of Why the
+different parts are needed can be found <a href="LibTooling.html">here</a>.</p>
Generally don't call link's "here". 

Instead: .. can be found in the <a href="LibTooling.html">LibTooling docs</a>

Comment at: docs/LibASTMatchersTutorial.html:262
@@ +261,3 @@
+<p>TODO: In header file!? In <tt>ForActions.h</tt>:</p>
+<pre class="doc_code">
Put the TODO into a comment?

Comment at: docs/LibASTMatchersTutorial.html:278
@@ +277,3 @@
+  ClangTool SyntaxTool(*Compilations, SourcePaths);
+  // TODO: Next line is off!
+  if (int status = Tool.run(newFrontendActionFactory(&Finder))) {
How so?


More information about the cfe-commits mailing list