[cfe-commits] [PATCH] test 'nodebug' on method
Paul.Robinson at am.sony.com
Tue Oct 23 10:30:12 PDT 2012
> why delete the C version? LGTM on a patch just adding the method case.
I didn't actually delete the C version, I did "svn mv" to rename the
test file to attr-debug.cpp and then added the test case for a method.
So, the patch shows the diff between the old .c file and the new .cpp
file, as well as showing that the old .c file was deleted. I didn't
remove any lines from the test. The diff looks strange just because
that's how SVN handles this situation.
Pls. commit if okay.
From: Rafael Espíndola [rafael.espindola at gmail.com]
Sent: Monday, October 22, 2012 7:13 PM
To: Robinson, Paul
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: [cfe-commits] [PATCH] test 'nodebug' on method
why delete the C version? LGTM on a patch just adding the method case.
On 22 October 2012 19:49, Robinson, Paul <Paul.Robinson at am.sony.com> wrote:
> I renamed test/Sema/attr-nodebug.c to *.cpp and added a method with
> __attribute__((nodebug)) to verify the attribute is accepted on a method.
> I was going to modify test/CodeGen/attr-nodebug.c in a similar way, but
> doing that exposed a bug, which I filed as PR14146.
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
More information about the cfe-commits