[cfe-commits] [PATCH] test 'nodebug' on method
Paul.Robinson at am.sony.com
Tue Oct 23 11:59:25 PDT 2012
> I guess my question then is why not just leave the .c file alone and
> add a c++ file with just the new test?
Because I keep seeing comments on the lists about not creating trivial
new test files, instead we should combine tests when it makes sense.
This test is all about the 'nodebug' attribute so all those tests
belong in one file. My new piece is specific to C++ so the test needed
to be turned into a C++ source.
From: Rafael Espíndola [rafael.espindola at gmail.com]
Sent: Tuesday, October 23, 2012 11:26 AM
To: Robinson, Paul
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: [cfe-commits] [PATCH] test 'nodebug' on method
> I didn't actually delete the C version, I did "svn mv" to rename the
> test file to attr-debug.cpp and then added the test case for a method.
> So, the patch shows the diff between the old .c file and the new .cpp
> file, as well as showing that the old .c file was deleted. I didn't
> remove any lines from the test. The diff looks strange just because
> that's how SVN handles this situation.
I guess my question then is why not just leave the .c file alone and
add a c++ file with just the new test?
> Pls. commit if okay.
More information about the cfe-commits