[cfe-commits] [PATCH/RFC, PowerPC] Extend 32-bit function arguments / return values

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Oct 22 11:23:12 PDT 2012

> Unfortunately, this change also causes about 20 spurious regression test
> failures on PowerPC, since IR output now frequently (i.e. for plain "int"
> types) contains an extra "signext" attribute, which throws off strict
> text-matching in various tests.  I've fixed those by optionally accepting
> "signext" (or "zeroext" as the case may be) via a regexp.   Not sure if
> this is really the best way of handling this ...

Not sure as well. It looks easy to forget to add this to new tests and
break a ppc64 bot. What abound adding some -triple=  to the tests?
LGTM with that change if you are ok with it. Just give it a day to see
if anyone else has another idea.

> To simplify review, I've attached two patches, one with the actual fix (and
> a new test for it), and one that contains all the signext/zeroext test
> changes.
> Would this be OK to commit?
> Bye,
> Ulrich


More information about the cfe-commits mailing list