[cfe-commits] r166236 - in /cfe/trunk: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGDebugInfo.cpp lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp test/CodeGen/de

Craig Topper craig.topper at gmail.com
Thu Oct 18 16:21:58 PDT 2012

Gating the code doesn't actually hide the perf problem. Because the perf
problem occurs in getPresumedLoc which calculates line and column number.
The debug code was calling getPresumedLoc twice once to only get the line
and once to only get the column, but this results in line and column
actually being calculated twice.

Perhaps the debug code should be refactored to only call getPresumedLoc

On Thu, Oct 18, 2012 at 3:05 PM, Eric Christopher <echristo at gmail.com>wrote:

> >
> > Hrm, I skimmed over the "no known current users". I hate such
> configuration flags, but this one makes sense.
> >
> Agreed. I just thought it was a waste to remove the code completely
> since someone may want the information.
> -eric
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121018/81f16a19/attachment.html>

More information about the cfe-commits mailing list