[cfe-commits] r165771 - in /cfe/trunk: include/clang/AST/ASTContext.h include/clang/AST/Comment.h lib/AST/ASTContext.cpp lib/AST/Comment.cpp lib/AST/CommentSema.cpp test/Index/overriding-method-comments.mm tools/libclang/CXComment.cpp
fjahanian at apple.com
Thu Oct 18 14:45:56 PDT 2012
On Oct 18, 2012, at 9:18 AM, Douglas Gregor <dgregor at apple.com> wrote:
> Hi Dmitri,
> On Oct 18, 2012, at 5:03 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>> (2) ParamCommandComment::getParamName and others used to return the
>> parameter name *as written* in \param command, without any regard to
>> resolving the name to an index in function parameter list. Now they
>> serve dual purpose of returning that parameter name or rewriting it.
>> This also breaks the purpose of getParamNameRange() nearby. I think
>> that getParamName should be split into two getter functions -- to get
>> parameter name as written (getParamName() as it was) or with some
>> magic rewriting (getParamNameInDecl()).
> I'm fine with splitting it into two functions. In general in the Clang ASTs, we have "getFoo()" be the semantic property and we add a "getFooAsWritten()" for the syntax as written. I suggest we do that.
This part is done in r166231.
> I think we should also deal with rewriting of \p. Yes, it means some lookup, but it'll give a more consistent experience.
> - Doug
More information about the cfe-commits