[cfe-commits] Bug 11709 Fix: va_list on ARM is not following AAPCS 7.1.4

[Weiming Zhao]

Hi Anton,

Attached is the fix for the issue and a test case for that.
The cause is that the original BuildVAArgExpr missed the case of a record type va_list.  I fixed that issue and I also refactored my original va_list construction code by removing the redundant call of creating RecordDecl.

Please review it.
Sorry for the inconvenience.

Weiming

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

-----Original Message-----
From: Anton Korobeynikov [mailto:anton at korobeynikov.info] 
Sent: Thursday, October 11, 2012 1:46 PM
To: weimingz at codeaurora.org
Cc: Jordan Rose; Logan Chien; cfe-commits at cs.uiuc.edu
Subject: Re: [cfe-commits] Bug 11709 Fix: va_list on ARM is not following AAPCS 7.1.4

Hi Weiming,

> Thanks for reviewing.
> I don't have commit access.
> Can you help to commit it?
I'm seeing the copy-ctor assertion every time someone is using __builtin_va_arg. Will you please fix and add the testcase for it as well?

Something like:

__builtin_va_list ap;
foo = __builtin_va_arg(ap, int)

Thanks!

--
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-an-assertion-fail-for-va_arg-on-ARM.patch
Type: application/octet-stream
Size: 3717 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121015/8ca90419/attachment.obj>