[cfe-commits] r165726 - /cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

Eric Christopher echristo at gmail.com
Thu Oct 11 16:07:31 PDT 2012

> -                .toCharUnitsFromBits(target.getPointerSizeInBits());
> +                .toCharUnitsFromBits(target.getPointerSizeInBits(0));
>      addr.push_back(llvm::ConstantInt::get(Int64Ty, offset.getQuantity()));
>      addr.push_back(llvm::ConstantInt::get(Int64Ty, llvm::DIBuilder::OpDeref));
>      addr.push_back(llvm::ConstantInt::get(Int64Ty, llvm::DIBuilder::OpPlus));

I'll acknowledge that I'm not the best example for this, but perhaps
an enum that
is "DefaultAddressSpace" or something less wordy would be a good idea to avoid
magic numbers?


More information about the cfe-commits mailing list