[cfe-commits] [PATCH] External Sema Source

Vassil Vassilev vvasilev at cern.ch
Thu Oct 11 11:11:16 PDT 2012

On 10/11/12 7:21 PM, Jordan Rose wrote:
> I don't know enough about this to make good comments, but rather than have "isMultiplex" as the field in Sema, why not call it "isOwned"? That's more in line with some of our other delegate-pattern uses, and it keeps it from being a temptation to start abusing the field. We could also some day in the future allow Sema to take ownership of arbitrary external sources as well, though that's clearly not a goal right now.
I agree that Sema should take the ownership it's external source (or at 
least we it should be specified with a flag while setting it). For 
example the ASTContext owns its ExternalASTSource.

My original intent was to try to keep the semantics (which is was not 
trivial for most of the reimplemented routines) of the existing code and 
extend it so that it can fit to our use case.

Otherwise I agree and I will rename the flag if we decide to keep it...

> Probably you should wait for Doug or someone to review this before committing.
> Jordan
> On Oct 11, 2012, at 8:02 , Vassil Vassilev <vasil.georgiev.vasilev at cern.ch> wrote:
>> Hi,
>> We need to attach multiple ExternalSources to Sema, to provide modules /and/ last resort lookup. Right now that's a pain. The attached patch makes this much easier, at (almost?) no runtime cost for the compiler. Okay to commit?
>> Vassil
>> <llvm-tools-clang-MultiplexExternalSemaSource.diff>_______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

More information about the cfe-commits mailing list