[cfe-commits] TableGen: Goodbye RTTI!
Jakob Stoklund Olesen
stoklund at 2pi.dk
Wed Oct 10 10:28:07 PDT 2012
On Oct 9, 2012, at 8:53 PM, Chris Lattner <sabre at nondot.org> wrote:
> On Oct 8, 2012, at 9:10 AM, Sean Silva <silvas at purdue.edu> wrote:
>> This patch set removes the last traces of RTTI from TableGen (both in
>> LLVM and Clang) and removes the crutch for enabling RTTI when building
> This all sounds fine to me, if it's ok with Jakob, go for it!
LGTM with these minor changes:
- The 'kind' enums should be protected, not public.
- The enumerator naming should follow the style guide.
- Don't use funky indentation in the enums.
More information about the cfe-commits