[cfe-commits] Fix for the -mms-bitfields commandline parameter

Jeremiah Zanin Jeremiah.Zanin at volition-inc.com
Wed Oct 10 07:44:24 PDT 2012

I moved the enum warning check into pragma-ms_struct.c and moved the new mms-bitfields-1.c test file into the Sema directory, distilling the tests down.


-----Original Message-----
From: Eli Friedman [mailto:eli.friedman at gmail.com]
Sent: Tuesday, October 09, 2012 6:41 PM
To: Jeremiah Zanin
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: [cfe-commits] Fix for the -mms-bitfields commandline parameter

On Tue, Oct 9, 2012 at 8:53 AM, Jeremiah Zanin <Jeremiah.Zanin at volition-inc.com> wrote:
> Ok, here's the updated patch.

+/// isMsStrust - Get whether or not this is an ms_struct which can ///
+be turned on with an attribute, pragma, or -mms-bitfields ///
+commandline option.

/// isMsStruct - Get whether or not this record uses ms_struct layout.
/// This which can be turned on with an attribute, pragma, or the /// -mms-bitfields command-line option.

There are some existing tests in test/Sema/pragma-ms_struct.c ; please move the tests which don't depend on the -mms-bitfields flag there, and add a test next to it to test -mms-bitfields.  The current "test/CodeGen/mms-bitfields.c" is not a good example to follow.



This message, including any attachments, may contain privileged and/or confidential information. Any distribution or use of this email by anyone other than the intended recipient(s) is strictly prohibited. If you are not the intended recipient, please notify the sender immediately and delete all copies. Thank you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mms-bitfields.patch
Type: application/octet-stream
Size: 7634 bytes
Desc: mms-bitfields.patch
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121010/1f1a07d7/attachment.obj>

More information about the cfe-commits mailing list