[cfe-commits] ObjCMethodDecl: s/Synthesized/PropertyAccessor/g

Jordan Rose jordan_rose at apple.com
Mon Oct 8 10:58:10 PDT 2012


Hi, all. I noticed today that ObjCMethodDecl's "isSynthesized" doesn't actually correlate with whether or not the definition of the method is actually synthesized. Instead, it just tells whether there is an associated property, meaning the method /could/ be synthesized if there is no definition in the @implementation.

This is certainly a useful thing to know, but I think the current name is misleading. (Anna and I both could have used this in the last week, but we didn't actually spot it because being @synthesized doesn't cover all methods called for properties.) Is it all right to change it to "isPropertyAccessor", or something similar?

Thanks,
Jordan



More information about the cfe-commits mailing list