[cfe-commits] r165195 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/TokenKinds.def include/clang/Parse/Parser.h include/clang/Sema/Sema.h lib/Parse/ParsePragma.cpp lib/Parse/ParsePragma.h lib/Parse/ParseStmt.cpp

[Eli Friedman]

On Wed, Oct 3, 2012 at 11:06 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> On Wed, Oct 3, 2012 at 7:36 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
>>
>> Author: efriedma
>> Date: Wed Oct  3 21:36:51 2012
>> New Revision: 165195
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=165195&view=rev
>> Log:
>> Permanently end the whole "pragma got handled by the parser too early"
>> mess by handling all pragmas which the parser touches uniformly.
>> <rdar://problem/12248901>, etc.
>
>
> Many thanks for doing this!
>
> I'm sorry to say that you missed one (spotted while trying to reinstate the
> fix for PR10101, which was blocked by this):
>
> #pragma clang arc_cf_code_audited begin/end

Ah... I missed it because it's implemented in a completely different
way from the other similar pragmas.  I'll take a look soon.

I just quickly checked, and it looks like there aren't any others; I
think the diagnostic pragmas are implemented in a safe manner.

-Eli