[cfe-commits] r164992 - /cfe/trunk/Makefile

David Blaikie dblaikie at gmail.com
Tue Oct 2 11:35:10 PDT 2012


On Mon, Oct 1, 2012 at 11:19 PM, Bill Wendling <isanbard at gmail.com> wrote:
> Author: void
> Date: Tue Oct  2 01:19:15 2012
> New Revision: 164992
>
> URL: http://llvm.org/viewvc/llvm-project?rev=164992&view=rev
> Log:
> Use an environment variable instead of what's in the make cmd goals.

Still makes me sad that this is an environment variable (admittedly
this isn't important - just an aesthetic issue for me) - what's the
use case for this? It just seems like this should naturally fall out
from any build command that wants to just build clang. If it doesn't
then someone may get sub-optimal builds because they don't know about
this environment variable they need to use.

>
> Modified:
>     cfe/trunk/Makefile
>
> Modified: cfe/trunk/Makefile
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/Makefile?rev=164992&r1=164991&r2=164992&view=diff
> ==============================================================================
> --- cfe/trunk/Makefile (original)
> +++ cfe/trunk/Makefile Tue Oct  2 01:19:15 2012
> @@ -27,7 +27,7 @@
>    DIRS := $(filter-out tools docs, $(DIRS))
>    OPTIONAL_DIRS :=
>  endif
> -ifeq ($(MAKECMDGOALS),clang-only)
> +ifeq ($(BUILD_CLANG_ONLY),YES)
>    DIRS := $(filter-out tools docs unittests, $(DIRS))
>         tools/driver tools/libclang
>    OPTIONAL_DIRS :=
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list