[cfe-commits] [PATCH] Implement AST dumper for Decls

Philip Craig reviews at llvm-reviews.chandlerc.com
Fri Sep 28 16:30:57 PDT 2012



================
Comment at: lib/AST/ASTDumper.h:1
@@ +1,2 @@
+//===--- ASTDumper.h - Dumping implementation for ASTS ----------*- C++ -*-===//
+//
----------------
Alexander Kornienko wrote:
> "ASTs"?
Fixed.

================
Comment at: lib/AST/StmtDumper.cpp:33
@@ -49,1 +32,3 @@
+    StmtDumper(ASTDumper &Dumper, raw_ostream &OS)
+      : Dumper(Dumper), OS(OS) {
     }
----------------
Alexander Kornienko wrote:
> Any reasons for a separate raw_ostream (there's one in the ASTDumper already)?
Changing that will add a lot of noise to the patch (unless you have a suggestion for a way to change it without needing to change all the users?). I plan to remove it from StmtDumper later.


http://llvm-reviews.chandlerc.com/D52



More information about the cfe-commits mailing list