[cfe-commits] [PATCH] Compatibility macro detection for the -Wimplicit-fallthrough diagnostic.

Alexander Kornienko reviews at llvm-reviews.chandlerc.com
Thu Sep 27 08:32:54 PDT 2012


  * replaced "SM.getFileEntryForID(SM.getFileID(L))" with a simple "L.isValid()" check (for macros defined on a command line);
  * compare token sequences instead of spelling.

Hi doug.gregor, rsmith,

http://llvm-reviews.chandlerc.com/D50

CHANGE SINCE LAST DIFF
  http://llvm-reviews.chandlerc.com/D50?vs=131&id=133#toc

Files:
  tools/clang/test/SemaCXX/switch-implicit-fallthrough-macro.cpp
  tools/clang/include/clang/Basic/DiagnosticSemaKinds.td
  tools/clang/include/clang/Lex/MacroInfo.h
  tools/clang/lib/Sema/AnalysisBasedWarnings.cpp
  tools/clang/lib/Lex/MacroInfo.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50.2.patch
Type: text/x-patch
Size: 11907 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120927/aded1a10/attachment.bin>


More information about the cfe-commits mailing list