[cfe-commits] [PATCH] [5/6] Hexagon TC: add cc1 defaults for hexagon-gcc, compatibility

[Sebastian Pop]

Hi,

This patch looks good.


Matthew Curtis wrote:
> 
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
> 

> From c6218606db62cb2bffa702d0daa3bb202a7d7a69 Mon Sep 17 00:00:00 2001
> From: Matthew Curtis <mcurtis at codeaurora.org>
> Date: Fri, 14 Sep 2012 12:32:41 -0500
> Subject: [PATCH 5/6] Hexagon TC: add cc1 defaults for hexagon-gcc
>  compatibility
> 
> ---
>  lib/Driver/Tools.cpp            |    5 ++---
>  test/Driver/hexagon-toolchain.c |   14 ++++++++++++++
>  2 files changed, 16 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp
> index baec90f..4840916 100644
> --- a/lib/Driver/Tools.cpp
> +++ b/lib/Driver/Tools.cpp
> @@ -1183,9 +1183,8 @@ void Clang::AddHexagonTargetArgs(const ArgList &Args,
>                        "hexagon"
>                        + toolchains::Hexagon_TC::GetTargetCPU(Args)));
>    CmdArgs.push_back("-fno-signed-char");
> -
> -  if (Args.hasArg(options::OPT_mqdsp6_compat))
> -    CmdArgs.push_back("-mqdsp6-compat");
> +  CmdArgs.push_back("-mqdsp6-compat");
> +  CmdArgs.push_back("-Wreturn-type");
>  
>    std::string SmallDataThreshold = GetHexagonSmallDataThresholdValue(Args);
>    if (!SmallDataThreshold.empty()) {
> diff --git a/test/Driver/hexagon-toolchain.c b/test/Driver/hexagon-toolchain.c
> index 7f7844a..d5ae73d 100644
> --- a/test/Driver/hexagon-toolchain.c
> +++ b/test/Driver/hexagon-toolchain.c
> @@ -518,3 +518,17 @@
>  // CHECK027-NEXT: "[[GNU_DIR:.*]]/bin/hexagon-as"
>  // CHECK027-NEXT: "[[GNU_DIR]]/bin/hexagon-ld"
>  // CHECK027-NOT:    "-pie"
> +
> +// -----------------------------------------------------------------------------
> +// Misc Defaults
> +// -----------------------------------------------------------------------------
> +// RUN: %clang -### -target hexagon-unknown-linux     \
> +// RUN:   -ccc-install-dir %S/Inputs/hexagon_tree/qc/bin \
> +// RUN:   %s 2>&1 \
> +// RUN:   | FileCheck -check-prefix=CHECK028 %s
> +// CHECK028:      "{{.*}}clang" "-cc1"
> +// CHECK028:        "-mqdsp6-compat"
> +// CHECK028:        "-Wreturn-type"
> +// CHECK028-NEXT: "[[GNU_DIR:.*]]/bin/hexagon-as"
> +// CHECK028-NEXT: "[[GNU_DIR]]/bin/hexagon-ld"
> +
> -- 
> 1.7.8.3
> 

> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation