[cfe-commits] r164143 - in /cfe/trunk: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp test/Analysis/additive-folding.cpp test/Sema/compare.c test/Sema/outof-range-constant-compare.c te

[David Blaikie]

On Tue, Sep 18, 2012 at 3:27 PM, Jordan Rose <jordan_rose at apple.com> wrote:
> Just curious: were these unparenthesized actually causing failures for you?

For that matter, why are these asserts even in the test file? It's not
being compiler/run...

(& if they really should be, I'd ideally like a string explaining the
assert, but I can accept that these are just in test files & perhaps
don't warrant that kind of verbosity/detail)

> On Sep 18, 2012, at 10:37 , Fariborz Jahanian <fjahanian at apple.com> wrote:
>
> Modified: cfe/trunk/test/SemaCXX/for-range-examples.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/for-range-examples.cpp?rev=164143&r1=164142&r2=164143&view=diff
> ==============================================================================
> --- cfe/trunk/test/SemaCXX/for-range-examples.cpp (original)
> +++ cfe/trunk/test/SemaCXX/for-range-examples.cpp Tue Sep 18 12:37:21 2012
> @@ -122,12 +122,12 @@
>   for (auto n : range(1, 5)) {
>     total += n;
>   }
> -  assert(total == 10);
> +  assert((total == 10));
>
>   for (auto n : range(10, 100, 10)) {
>     total += n;
>   }
> -  assert(total == 460);
> +  assert((total == 460));
>
>   map_range::vector<char> chars;
>   chars.push_back('a');
> @@ -136,7 +136,7 @@
>   for (char c : chars) {
>     ++total;
>   }
> -  assert(total == 463);
> +  assert((total == 463));
>
>   typedef map_range::tuple<int, double> T;
>   map_range::vector<T> pairs;
> @@ -146,7 +146,7 @@
>   for (auto a : map(map_range::mem_fun(&T::get<int>), pairs)) {
>     total += a;
>   }
> -  assert(total == 500);
> +  assert((total == 500));
> }
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>