[cfe-commits] [PATCH] Do not pass lib32 sub-directory to the linker when target is MIPS 32-bit

[Chandler Carruth]

LGTM, thanks for the explanation and the comments!

Also, yay test cases!

One grammar nit:

+  // targets. It contains N32 ABI binaries. Do not
+  // use this folder if produce code for other ABI.

"Do not use this folder when producing code for the normal ABI."? However
you want to phrase "normal ABI", I'm assuming you mean anything other than
N32 ABI.


On Thu, Sep 13, 2012 at 1:20 PM, Simon Atanasyan <satanasyan at mips.com>wrote:

> Hi,
>
> Clang driver considers lib32 directory as a usual folder with 32-bit
> binaries. That is not correct for MIPS where this directory contains
> N32 ABI binaries. N32 is a minor variation on the high performance
> 64-bit ABI and is not used to compile 32-bit code. That's why Clang
> passes incorrect paths to the linker if user has MIPS multilib
> environment and wants to compile 32-bit code.
>
> The attached patch fixes this problem. It does not use "lib32"
> directory to create a library/object files paths list when target is
> MIPS 32-bit. Later I plan to implement full N32 ABI support and
> provide more test cases.
>
> Please review the patch.
>
> --
> Simon
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120913/7d135562/attachment.html>