[cfe-commits] r163776 - /cfe/trunk/lib/Frontend/InitHeaderSearch.cpp

[NAKAMURA Takumi]

2012/9/13 Chandler Carruth <chandlerc at google.com>:
> On Wed, Sep 12, 2012 at 10:53 PM, NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
>>
>> Author: chapuni
>> Date: Thu Sep 13 00:53:23 2012
>> New Revision: 163776
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=163776&view=rev
>> Log:
>> InitHeaderSearch.cpp: [mingw] Handle DOSish paths only on Win32 hosts.
>
>
> No, this is completely wrong. The set of paths to search for headers should
> never have anything to do with the *host*, only the *target*. Please revert
> this and let's actually talk about the problem you're solving here.

I think Driveletter-based paths would be useless and ignored safely on
non-Win32 hosts (including cygwin). It's host's issue really.

> If you're trying to clean up the mingw header search, please as a first step
> let's move it to the Driver.

I would like bots (esp., cross things) let fine at first. But you are
right, I might reconstruct headersearch with moving stuff to the
driver. Thank you.

ps. I wonder how sysroot stuff could be applied for mingw targets...

...Takumi